Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(40)

Issue 1266493007: Set concurrency to 1 in Configuration in debug mode. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Set concurrency to 1 in Configuration in debug mode. Tests were already not being run concurrently due to the debugging code path, but it's a good idea to have the configuration reflect that. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/d983b1b7b9f1236404fe91dc6c99578f99222fe2

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M lib/src/runner/configuration.dart View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-04 20:34:24 UTC) #1
kevmoo
lgtm
5 years, 4 months ago (2015-08-04 20:42:32 UTC) #2
nweiz
5 years, 4 months ago (2015-08-04 20:51:45 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d983b1b7b9f1236404fe91dc6c99578f99222fe2 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698