Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Issue 1266273007: Make Configuration explicitly constructable. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make Configuration explicitly constructable. This will be more user-friendly once we make the runner's innards a package, and it'll help us be able to pass the config into more places. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/fc610eb197b3496e1f3f35516f4776ccde701212

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -48 lines) Patch
M lib/src/runner/configuration.dart View 2 chunks +72 lines, -48 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-08-04 20:52:03 UTC) #1
kevmoo
lgtm
5 years, 4 months ago (2015-08-04 20:56:16 UTC) #2
nweiz
5 years, 4 months ago (2015-08-04 21:01:50 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fc610eb197b3496e1f3f35516f4776ccde701212 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698