Issue 12662010: dart:io | Handle drive letters in Path.relativeTo on Windows.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12662010: dart:io | Handle drive letters in Path.relativeTo on Windows. (Closed)

Created:
7 years, 9 months ago by Bill Hesse

Modified:
7 years, 9 months ago

Reviewers:
Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Handle drive letters in Path.relativeTo on Windows. BUG=dartbug.com/4861 Committed: https://code.google.com/p/dart/source/detail?r=20026

Patch Set 3 : Reformat exception strings. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+63 lines, -2 lines)			Patch
	M	sdk/lib/io/path_impl.dart	View	1 2	3 chunks	+33 lines, -2 lines	0 comments	Download
	M	tests/standalone/io/path_test.dart	View	1	2 chunks	+30 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/12662010/diff/2001/sdk/lib/io/path_impl.dart File sdk/lib/io/path_impl.dart (right): https://codereview.chromium.org/12662010/diff/2001/sdk/lib/io/path_impl.dart#newcode53 sdk/lib/io/path_impl.dart:53: throw new ArgumentError(""" Please keep using concatenation of ...

7 years, 9 months ago (2013-03-14 13:53:32 UTC) #2

Bill Hesse

7 years, 9 months ago (2013-03-14 14:50:28 UTC) #3

Message was sent while issue was closed.

Committed patchset #3 manually as r20026 (presubmit successful).

Expand Messages | Collapse Messages

Issue 12662010: dart:io | Handle drive letters in Path.relativeTo on Windows. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Fix bugs. #

Patch Set 3 : Reformat exception strings. #

Messages