Issue 1266193003: Introduce two utility elements for the cpu profiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1266193003: Introduce two utility elements for the cpu profiler (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
turnidge, rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org, turnidge, rmacnak

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Introduce two utility elements for the cpu profiler - Add <sample-buffer-control> which manages fetching a sample buffer from an isolate. - Remove duplicate code by using <sample-buffer-control> in both the tree and table profile views. - Add <stack-trace-tree-config> which manages how a stack trace tree should be displayed (function or code objects, bottom up or top down). - Remove duplicate code by using <stack-trace-tree-config> in both the tree and table profile views. This is the first of many CLs refactoring the CPU profile related code in Observatory. This introduces some naming inconsistencies (CpuProfile vs. SampleBuffer) that will converge to SampleBuffer over time. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/de035901a17b88cfa67e16aade186eb4e40294d6

Patch Set 1 #

Patch Set 2 : #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+403 lines, -404 lines)			Patch
M	runtime/observatory/lib/src/elements/cpu_profile.dart	View	8 chunks	+219 lines, -205 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/cpu_profile.html	View	4 chunks	+174 lines, -199 lines	0 comments	Download
M	runtime/observatory/lib/src/elements/css/shared.css	View	1 chunk	+10 lines, -0 lines	0 comments	Download

Messages

Total messages: 6 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Cutch

5 years, 4 months ago (2015-07-31 21:19:22 UTC) #6

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
de035901a17b88cfa67e16aade186eb4e40294d6 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages