Fix empty zlib deflate and early close of responses.

Fix empty zlib deflate and early close of responses.


BUG=

Committed: https://code.google.com/p/dart/source/detail?r=19910

[Søren Gjesse, 2013-03-13 08:08:21]

lgtm

https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/data_transformer.dart
File sdk/lib/io/data_transformer.dart (right):

https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/data_transformer.d...
sdk/lib/io/data_transformer.dart:39: bool _haveData = false;
_haveData -> _empty?

https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:440: .any((encoding) => encoding.toLowerCase() ==
"gzip") &&
Trim whitespace here as well.

https://codereview.chromium.org/12661003/diff/1/tests/standalone/io/http_comp...
File tests/standalone/io/http_compression_test.dart (right):

https://codereview.chromium.org/12661003/diff/1/tests/standalone/io/http_comp...
tests/standalone/io/http_compression_test.dart:23:
request.headers.set(HttpHeaders.ACCEPT_ENCODING, "gzip,deflate");
Also test with other Accept-Encoding headers, like:

gzip
deflate
gzip, deflate
gzip ,deflate
gzip  ,  deflate
deflate,gzip
deflate, gzip
deflate ,gzip
deflate  ,  gzip
abc,deflate  ,  gzip,def,,,ghi  ,jkl
xgzip
gzipx

[Søren Gjesse, 2013-03-13 08:09:34]

On 2013/03/13 08:08:21, Søren Gjesse wrote:
> lgtm
> 
>
https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/data_transformer.dart
> File sdk/lib/io/data_transformer.dart (right):
> 
>
https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/data_transformer.d...
> sdk/lib/io/data_transformer.dart:39: bool _haveData = false;
> _haveData -> _empty?
> 
> https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/http_impl.dart
> File sdk/lib/io/http_impl.dart (right):
> 
>
https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/http_impl.dart#new...
> sdk/lib/io/http_impl.dart:440: .any((encoding) => encoding.toLowerCase() ==
> "gzip") &&
> Trim whitespace here as well.
> 
>
https://codereview.chromium.org/12661003/diff/1/tests/standalone/io/http_comp...
> File tests/standalone/io/http_compression_test.dart (right):
> 
>
https://codereview.chromium.org/12661003/diff/1/tests/standalone/io/http_comp...
> tests/standalone/io/http_compression_test.dart:23:
> request.headers.set(HttpHeaders.ACCEPT_ENCODING, "gzip,deflate");
> Also test with other Accept-Encoding headers, like:
> 
> gzip
> deflate
> gzip, deflate
> gzip ,deflate
> gzip  ,  deflate
> deflate,gzip
> deflate, gzip
> deflate ,gzip
> deflate  ,  gzip
> abc,deflate  ,  gzip,def,,,ghi  ,jkl
> xgzip
> gzipx

Maybe also several Accept-Encoding headers

Accept-Encoding: gzip
Accept-Encoding: deflate
Accept-Encoding: abc

guess we cannot make this using HttpClient

[Anders Johnsen, 2013-03-13 08:24:58]

Committed patchset #2 manually as r19910 (presubmit successful).

[Anders Johnsen, 2013-03-13 08:25:00]

Landing

https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/data_transformer.dart
File sdk/lib/io/data_transformer.dart (right):

https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/data_transformer.d...
sdk/lib/io/data_transformer.dart:39: bool _haveData = false;
On 2013/03/13 08:08:22, Søren Gjesse wrote:
> _haveData -> _empty?

Done.

https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/http_impl.dart
File sdk/lib/io/http_impl.dart (right):

https://codereview.chromium.org/12661003/diff/1/sdk/lib/io/http_impl.dart#new...
sdk/lib/io/http_impl.dart:440: .any((encoding) => encoding.toLowerCase() ==
"gzip") &&
On 2013/03/13 08:08:22, Søren Gjesse wrote:
> Trim whitespace here as well.

Done.

https://codereview.chromium.org/12661003/diff/1/tests/standalone/io/http_comp...
File tests/standalone/io/http_compression_test.dart (right):

https://codereview.chromium.org/12661003/diff/1/tests/standalone/io/http_comp...
tests/standalone/io/http_compression_test.dart:23:
request.headers.set(HttpHeaders.ACCEPT_ENCODING, "gzip,deflate");
On 2013/03/13 08:08:22, Søren Gjesse wrote:
> Also test with other Accept-Encoding headers, like:
> 
> gzip
> deflate
> gzip, deflate
> gzip ,deflate
> gzip  ,  deflate
> deflate,gzip
> deflate, gzip
> deflate ,gzip
> deflate  ,  gzip
> abc,deflate  ,  gzip,def,,,ghi  ,jkl
> xgzip
> gzipx

Done.