Add box slow path allocation stub to static calls target table

Add box slow path allocation stub to static calls target table

- Fixes a crash when tracing double allocation in optimized code.

R=rmacnak@google.com

Committed: https://github.com/dart-lang/sdk/commit/59f50474c28214cd5bcdb13928fb9cbcdbc4500a

[Cutch, 2015-08-03 19:56:51]

johnmccutchan@google.com changed reviewers:
+ fschneider@google.com, rmacnak@google.com

[rmacnak, 2015-08-03 20:15:16]

lgtm

Florian's refactoring of the assembler to take a code instead of external label
might subsume this in the future.

[Cutch, 2015-08-03 20:19:32]

On 2015/08/03 20:15:16, rmacnak wrote:
> lgtm
> 
> Florian's refactoring of the assembler to take a code instead of external
label
> might subsume this in the future.

Florian- I'm going to land this. Let me know if you have any issues with adding
the stubs to the static call list (allocation profiling of inlined allocations
requires this).

[Cutch, 2015-08-03 20:20:02]

Committed patchset #1 (id:1) manually as
59f50474c28214cd5bcdb13928fb9cbcdbc4500a (presubmit successful).

[Florian Schneider, 2015-08-04 08:25:36]

On 2015/08/03 20:19:32, Cutch wrote:
> On 2015/08/03 20:15:16, rmacnak wrote:
> > lgtm
> > 
> > Florian's refactoring of the assembler to take a code instead of external
> label
> > might subsume this in the future.
> 
> Florian- I'm going to land this. Let me know if you have any issues with
adding
> the stubs to the static call list (allocation profiling of inlined allocations
> requires this).

Are only allocation-stub calls needed in this list? What about the slow-path of
context allocation?

[Cutch, 2015-08-04 17:46:20]

On 2015/08/04 08:25:36, Florian Schneider wrote:
> On 2015/08/03 20:19:32, Cutch wrote:
> > On 2015/08/03 20:15:16, rmacnak wrote:
> > > lgtm
> > > 
> > > Florian's refactoring of the assembler to take a code instead of external
> > label
> > > might subsume this in the future.
> > 
> > Florian- I'm going to land this. Let me know if you have any issues with
> adding
> > the stubs to the static call list (allocation profiling of inlined
allocations
> > requires this).
> 
> Are only allocation-stub calls needed in this list? What about the slow-path
of
> context allocation?

Only the allocation-stub calls are needed. We don't support tracing of context
allocation right now.

[Florian Schneider, 2015-08-05 08:43:40]

https://codereview.chromium.org/1266033003/diff/1/runtime/vm/intermediate_lan...
File runtime/vm/intermediate_language_ia32.cc (right):

https://codereview.chromium.org/1266033003/diff/1/runtime/vm/intermediate_lan...
runtime/vm/intermediate_language_ia32.cc:2135: locs());
Shouldn't this call to the array allocation stub also be added?