Issue 12659008: Fix a couple broken tests in pub/validator_test.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12659008: Fix a couple broken tests in pub/validator_test. (Closed)

Created:
7 years, 9 months ago by nweiz

Modified:
7 years, 9 months ago

Reviewers:
Bob Nystrom

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Fix a couple broken tests in pub/validator_test. These tests were marked as test() rather than integration() and so their schedules weren't getting run at all. Committed: https://code.google.com/p/dart/source/detail?r=20238

Patch Set 1 #

Patch Set 2 : Remove "solo_". #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+7 lines, -6 lines)			Patch
M	utils/pub/package.dart	View		1 chunk	+4 lines, -3 lines	0 comments	Download
M	utils/pub/validator/compiled_dartdoc.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	utils/tests/pub/validator_test.dart	View	1	2 chunks	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

nweiz

7 years, 9 months ago (2013-03-19 20:37:10 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r20238 (presubmit successful).

Expand Messages | Collapse Messages