- Don't wait for the client to time out before finishing the load

- Don't wait for the client to time out before finishing the load
  of source code from http.

R=johnmccutchan@google.com

Committed: https://code.google.com/p/dart/source/detail?r=31593

[Cutch, 2014-01-07 23:59:11]

lgtm

[Ivan Posva, 2014-01-08 00:12:36]

Committed patchset #1 manually as r31593 (presubmit successful).

[Anders Johnsen, 2014-01-09 14:09:29]

DBC

https://codereview.chromium.org/126583003/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/126583003/diff/1/runtime/bin/builtin.dart#new...
runtime/bin/builtin.dart:90: _client.close(force:true);
It sounds like it would be better to re-use the http client. That we it would
use keep-alive for multiple requests.

[Ivan Posva, 2014-01-10 06:40:20]

-Ivan

https://codereview.chromium.org/126583003/diff/1/runtime/bin/builtin.dart
File runtime/bin/builtin.dart (right):

https://codereview.chromium.org/126583003/diff/1/runtime/bin/builtin.dart#new...
runtime/bin/builtin.dart:90: _client.close(force:true);
On 2014/01/09 14:09:29, Anders Johnsen wrote:
> It sounds like it would be better to re-use the http client. That we it would
> use keep-alive for multiple requests.

We cannot keep the client alive as the request is synchronous with the loading
execution (we need to exit this run loop before we can make forward progress).
Also there is no guarantee that the next request is going to the same host, so
you would not necessarily be able to reuse the connection anyway.