Fix issue 23942 by updating expectations.

Fix issue 23942 by updating expectations.

Some tasks might resume at SafepointThreads for one extra verfication round,
where they will see less than kTaskCount copies of the marker smi.

Also fix indentation.

BUG=23942
Committed: https://github.com/dart-lang/sdk/commit/5583bc2b5f0c5ce982dc8dbcec106a3d0568f30b

[koda, 2015-08-01 05:58:34]

koda@google.com changed reviewers:
+ iposva@google.com

[koda, 2015-08-01 06:01:12]

The indentation change seems to confuse the diff tool.

The only real change is to add lines 308-310 and remove the comment on line 294.

Submitting TBR.

[koda, 2015-08-01 06:03:36]

Committed patchset #2 (id:20001) manually as
5583bc2b5f0c5ce982dc8dbcec106a3d0568f30b (presubmit successful).

[Ivan Posva, 2015-08-03 16:07:46]

LGTM -ip

https://codereview.chromium.org/1265503004/diff/20001/runtime/vm/thread_test.cc
File runtime/vm/thread_test.cc (right):

https://codereview.chromium.org/1265503004/diff/20001/runtime/vm/thread_test....
runtime/vm/thread_test.cc:293: EXPECT(label.Equals("foo"));
Isn't this a potential source for flaky failures due to the fact that the Dart
thread might execute any other code such as compilation when it is interrupted?

https://codereview.chromium.org/1265503004/diff/20001/runtime/vm/thread_test....
runtime/vm/thread_test.cc:302: isolate_->thread_registry()->ResumeAllThreads();
Is there a surviving All here?

[koda, 2015-08-03 16:15:47]

https://codereview.chromium.org/1265503004/diff/20001/runtime/vm/thread_test.cc
File runtime/vm/thread_test.cc (right):

https://codereview.chromium.org/1265503004/diff/20001/runtime/vm/thread_test....
runtime/vm/thread_test.cc:293: EXPECT(label.Equals("foo"));
On 2015/08/03 16:07:46, Ivan Posva wrote:
> Isn't this a potential source for flaky failures due to the fact that the Dart
> thread might execute any other code such as compilation when it is
interrupted?

Compilation changes the VM tag, not the user tag. The latter should remain
"foo".

https://codereview.chromium.org/1265503004/diff/20001/runtime/vm/thread_test....
runtime/vm/thread_test.cc:302: isolate_->thread_registry()->ResumeAllThreads();
On 2015/08/03 16:07:46, Ivan Posva wrote:
> Is there a surviving All here?

Yes. I can rename it in a future CL.