Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(422)

Issue 1265453005: Code clean-up, mostly constructors (Closed)

Created:
5 years, 4 months ago by Brian Wilkerson
Modified:
5 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -93 lines) Patch
M pkg/analyzer/lib/src/generated/ast.dart View 3 chunks +5 lines, -19 lines 0 comments Download
M pkg/analyzer/lib/src/generated/constant.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 4 chunks +5 lines, -18 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error.dart View 6 chunks +6 lines, -14 lines 0 comments Download
M pkg/analyzer/lib/src/generated/html.dart View 1 chunk +1 line, -5 lines 0 comments Download
M pkg/analyzer/lib/src/generated/resolver.dart View 9 chunks +10 lines, -23 lines 0 comments Download
M pkg/analyzer/lib/src/generated/scanner.dart View 1 chunk +1 line, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/sdk.dart View 3 chunks +2 lines, -7 lines 0 comments Download
M pkg/analyzer/test/generated/compile_time_error_code_test.dart View 1 chunk +0 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
5 years, 4 months ago (2015-07-28 17:59:40 UTC) #2
scheglov
LGTM
5 years, 4 months ago (2015-07-28 18:09:41 UTC) #3
Brian Wilkerson
5 years, 4 months ago (2015-07-28 18:12:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
2ec502a583599f01d023aea763aec42cb30c066b (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698