Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(420)

Issue 1265153005: Observatory fixes: (Closed)

Created:
5 years, 4 months ago by turnidge
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, rmacnak, Cutch, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Observatory fixes: - Fix bug where we incorrectly tell the user to use "anext". - Allow debugger input box to retain focus when curly-blocks are expanded. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/fa1d1e9fafc4cdfe02840d1d979b517c7bde0426

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -3 lines) Patch
M runtime/observatory/lib/src/elements/curly_block.dart View 1 chunk +0 lines, -1 line 0 comments Download
M runtime/observatory/tests/service/async_continuation_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/service_event.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
turnidge
5 years, 4 months ago (2015-08-03 20:05:05 UTC) #2
Cutch
lgtm
5 years, 4 months ago (2015-08-03 20:05:52 UTC) #3
turnidge
5 years, 4 months ago (2015-08-03 20:16:35 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
fa1d1e9fafc4cdfe02840d1d979b517c7bde0426 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698