Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Issue 1264683002: Fix crash when reading the Richards snapshot generated on using a the 32 bit dart binary. (Closed)

Created:
5 years, 4 months ago by siva
Modified:
5 years, 4 months ago
Reviewers:
rmacnak
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix crash when reading the Richards snapshot generated on using a the 32 bit dart binary. When transitionting a Mint object to a Smi on 64 bit architectures the corresponding object id was not preserved in the backward references table. BUG= R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/ffbbfb52e10e81306f6ee8b0d0d5559b1714074f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M runtime/vm/raw_object_snapshot.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
siva
5 years, 4 months ago (2015-07-29 17:41:38 UTC) #2
rmacnak
lgtm
5 years, 4 months ago (2015-07-29 18:16:37 UTC) #3
siva
5 years, 4 months ago (2015-07-30 00:03:18 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
ffbbfb52e10e81306f6ee8b0d0d5559b1714074f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698