Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(355)

Issue 126453002: pkg/http_server: fix broken test (Closed)

Created:
6 years, 11 months ago by kevmoo
Modified:
6 years, 11 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M pkg/http_server/test/utils.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
kevmoo
Must use 'server' inside a closure or else it gets bound to null Fixes build ...
6 years, 11 months ago (2014-01-07 20:48:24 UTC) #1
Siggi Cherem (dart-lang)
lgtm
6 years, 11 months ago (2014-01-07 20:58:21 UTC) #2
kevmoo
6 years, 11 months ago (2014-01-07 21:03:24 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r31573 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698