Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(809)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1264413002: - Implement resource loading via the Resource class. (Closed)

Created:
5 years, 4 months ago by Ivan Posva
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

- Implement resource loading via the Resource class. R=asiva@google.com Committed: https://github.com/dart-lang/sdk/commit/f63db4960cf66bc0f19ea1eceb4549efead30dfc

Patch Set 1 #

Patch Set 2 : Simplify Stream creation. #

Total comments: 2

Patch Set 3 : Address review comments, simplified error handling. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -77 lines) Patch
M runtime/bin/builtin.dart View 1 2 17 chunks +106 lines, -53 lines 0 comments Download
M runtime/lib/core_patch.dart View 1 chunk +0 lines, -24 lines 0 comments Download
M runtime/lib/core_sources.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M runtime/lib/internal_patch.dart View 1 chunk +2 lines, -0 lines 0 comments Download
A runtime/lib/resource_patch.dart View 1 2 1 chunk +68 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Ivan Posva
5 years, 4 months ago (2015-08-04 16:32:05 UTC) #2
Ivan Posva
5 years, 4 months ago (2015-08-04 18:25:27 UTC) #4
siva
lgtm https://codereview.chromium.org/1264413002/diff/20001/runtime/bin/builtin.dart File runtime/bin/builtin.dart (right): https://codereview.chromium.org/1264413002/diff/20001/runtime/bin/builtin.dart#newcode758 runtime/bin/builtin.dart:758: // Dangling comment start ? https://codereview.chromium.org/1264413002/diff/20001/runtime/lib/resource_patch.dart File runtime/lib/resource_patch.dart ...
5 years, 4 months ago (2015-08-04 21:48:24 UTC) #5
Ivan Posva
5 years, 4 months ago (2015-08-04 22:39:18 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
f63db4960cf66bc0f19ea1eceb4549efead30dfc (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698