Issue 12644004: Making Indexed DB's cursor stream not auto-advance if no subscribers

Issue 12644004: Making Indexed DB's cursor stream not auto-advance if no subscribers (Closed)

Created:
7 years, 9 months ago by blois

Modified:
7 years, 9 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Making Indexed DB's cursor stream not auto-advance if no subscribers BUG=8552 Committed: https://code.google.com/p/dart/source/detail?r=19667

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -3 lines)			Patch
M	sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart	View	1 chunk	+1 line, -1 line	2 comments	Download
M	sdk/lib/indexed_db/dartium/indexed_db_dartium.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	tools/dom/templates/html/impl/impl_IDBObjectStore.darttemplate	View	1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

sra1

lgtm https://codereview.chromium.org/12644004/diff/1/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (right): https://codereview.chromium.org/12644004/diff/1/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart#newcode1017 sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:1017: if (autoAdvance == true && controller.hasSubscribers) { is ...

7 years, 9 months ago (2013-03-08 00:51:33 UTC) #2

blois

https://codereview.chromium.org/12644004/diff/1/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart File sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart (right): https://codereview.chromium.org/12644004/diff/1/sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart#newcode1017 sdk/lib/indexed_db/dart2js/indexed_db_dart2js.dart:1017: if (autoAdvance == true && controller.hasSubscribers) { On 2013/03/08 ...

7 years, 9 months ago (2013-03-08 01:35:47 UTC) #3

blois

7 years, 9 months ago (2013-03-08 01:37:08 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19667 (presubmit successful).

Expand Messages | Collapse Messages