dart2js: fix a few TODOs in the startup emitter.

dart2js: fix a few TODOs in the startup emitter.

R=sigmund@google.com

Committed: https://github.com/dart-lang/sdk/commit/47c5878757fffa900ff97d9600188d938a4c67b2

[floitsch, 2015-08-03 17:28:50]

floitsch@google.com changed reviewers:
+ sigmund@google.com

[Siggi Cherem (dart-lang), 2015-08-04 01:54:55]

lgtm

https://codereview.chromium.org/1264303002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1264303002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1253: //
On V8, the 'intern' function converts a string to a symbol, which
any reason why not define this as a function with a name and use it in both
places?

[floitsch, 2015-08-04 11:54:53]

https://codereview.chromium.org/1264303002/diff/20001/pkg/compiler/lib/src/js...
File pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart
(right):

https://codereview.chromium.org/1264303002/diff/20001/pkg/compiler/lib/src/js...
pkg/compiler/lib/src/js_emitter/startup_emitter/fragment_emitter.dart:1253: //
On V8, the 'intern' function converts a string to a symbol, which
On 2015/08/04 01:54:54, Siggi Cherem (dart-lang) wrote:
> any reason why not define this as a function with a name and use it in both
> places?

The copy is from a different emitter. We could create a new generator (like for
other stubs), but I'm not sure it's worth it.

If you think, we should do that, leave a comment, and I will do a follow-up CL.

[floitsch, 2015-08-04 12:17:20]

Committed patchset #2 (id:20001) manually as
47c5878757fffa900ff97d9600188d938a4c67b2 (presubmit successful).