Issue 126393004: Another fix for setRange on typed data and their views: use byte offsets in native code.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 126393004: Another fix for setRange on typed data and their views: use byte offsets in native code. (Closed)

Created:
6 years, 11 months ago by srdjan

Modified:
6 years, 11 months ago

Reviewers:
Cutch

CC:
reviews_dartlang.org, vm-dev_dartlang.org, sra1

Base URL:
http://dart.googlecode.com/svn/branches/bleeding_edge/dart/

Visibility:
Public.

Another fix for setRange on typed data and their views: use byte offsets in native code. Adapted checks to do the same as dart2js R=johnmccutchan@google.com Committed: https://code.google.com/p/dart/source/detail?r=31592

Created: 6 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+47 lines, -30 lines)			Patch
M	runtime/lib/typed_data.cc	View		2 chunks	+9 lines, -14 lines	0 comments	Download
M	runtime/lib/typed_data.dart	View	1	2 chunks	+38 lines, -14 lines	0 comments	Download
M	tests/lib/lib.status	View		1 chunk	+0 lines, -2 lines	0 comments	Download

Total messages: 3 (0 generated)

srdjan

6 years, 11 months ago (2014-01-08 00:08:57 UTC) #3

Message was sent while issue was closed.

Committed patchset #2 manually as r31592 (presubmit successful).