Issue 1263843004: Temporary fix for pub crash by canonicalizing type only if the IsCreatedFromSnapshot bit is true (i…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1263843004: Temporary fix for pub crash by canonicalizing type only if the IsCreatedFromSnapshot bit is true (i… (Closed)

Created:
5 years, 4 months ago by siva

Modified:
5 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Temporary fix for pub crash by canonicalizing type only if the IsCreatedFromSnapshot bit is true (i.e restored the condition back to the way it used to be). BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/ba415408e9c164ac0d760ffe059091bd6bc7140d

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -2 lines)			Patch
	M	runtime/vm/raw_object_snapshot.cc	View		2 chunks	+6 lines, -2 lines	0 comments	Download
	M	runtime/vm/snapshot_test.cc	View	1	2 chunks	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

siva

5 years, 4 months ago (2015-08-01 00:04:36 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
ba415408e9c164ac0d760ffe059091bd6bc7140d (presubmit successful).