Display metadata about out-of-band callbacks in scheduled test errors.

Display metadata about out-of-band callbacks in scheduled test errors.

Committed: https://code.google.com/p/dart/source/detail?r=19896

[Bob Nystrom, 2013-03-12 20:08:51]

Couple of nits then LGTM.

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/sch...
File pkg/scheduled_test/lib/scheduled_process.dart (right):

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/sch...
pkg/scheduled_test/lib/scheduled_process.dart:176: "'${this.description}'");
Is "this." still needed here (and above)?

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/sch...
pkg/scheduled_test/lib/scheduled_process.dart:207: "'${this.description}' to
die");
Ditto.

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
File pkg/scheduled_test/lib/src/schedule.dart (right):

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/schedule.dart:351: /// after the queue finished
running its tasks.
finished -> finishes.

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/schedule.dart:469:
_pendingCallbacks.add(description);;
;;

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
File pkg/scheduled_test/lib/src/schedule_error.dart (right):

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/schedule_error.dart:56: this.schedule = schedule,
Are the "this."s needed here?

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/schedule_error.dart:60: : new
List<String>.from(schedule.currentQueue.pendingCallbacks),
schedule.currentQueue.pendingCallbacks.toList()

[nweiz, 2013-03-12 20:56:51]

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/sch...
File pkg/scheduled_test/lib/scheduled_process.dart (right):

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/sch...
pkg/scheduled_test/lib/scheduled_process.dart:176: "'${this.description}'");
On 2013/03/12 20:08:51, Bob Nystrom wrote:
> Is "this." still needed here (and above)?

Nope. Done.

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/sch...
pkg/scheduled_test/lib/scheduled_process.dart:207: "'${this.description}' to
die");
On 2013/03/12 20:08:51, Bob Nystrom wrote:
> Ditto.

Done.

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
File pkg/scheduled_test/lib/src/schedule.dart (right):

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/schedule.dart:351: /// after the queue finished
running its tasks.
On 2013/03/12 20:08:51, Bob Nystrom wrote:
> finished -> finishes.

Done.

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/schedule.dart:469:
_pendingCallbacks.add(description);;
On 2013/03/12 20:08:51, Bob Nystrom wrote:
> ;;

Done.

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
File pkg/scheduled_test/lib/src/schedule_error.dart (right):

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/schedule_error.dart:56: this.schedule = schedule,
On 2013/03/12 20:08:51, Bob Nystrom wrote:
> Are the "this."s needed here?

No, removed.

https://codereview.chromium.org/12637020/diff/2001/pkg/scheduled_test/lib/src...
pkg/scheduled_test/lib/src/schedule_error.dart:60: : new
List<String>.from(schedule.currentQueue.pendingCallbacks),
On 2013/03/12 20:08:51, Bob Nystrom wrote:
> schedule.currentQueue.pendingCallbacks.toList()

Done.

[nweiz, 2013-03-12 20:57:18]

Committed patchset #2 manually as r19896 (presubmit successful).