Issue 1263593005: Disable timeouts when debugging.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1263593005: Disable timeouts when debugging. (Closed)

Created:
5 years, 4 months ago by nweiz

Modified:
5 years, 4 months ago

Reviewers:
kevmoo

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/test@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Disable timeouts when debugging. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/4811a3fd06224bb2c5c44f73a985eeb422154ee5

Patch Set 1 #

Total comments: 2

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+40 lines, -1 line)			Patch
	M	lib/src/runner.dart	View		3 chunks	+2 lines, -1 line	0 comments	Download
	M	test/runner/pause_after_load_test.dart	View		1 chunk	+38 lines, -0 lines	2 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

kevmoo

One nit, otherwise LGTM https://codereview.chromium.org/1263593005/diff/1/test/runner/pause_after_load_test.dart File test/runner/pause_after_load_test.dart (right): https://codereview.chromium.org/1263593005/diff/1/test/runner/pause_after_load_test.dart#newcode249 test/runner/pause_after_load_test.dart:249: var test = runTest( perhaps ...

5 years, 4 months ago (2015-07-28 22:43:56 UTC) #2

nweiz

https://codereview.chromium.org/1263593005/diff/1/test/runner/pause_after_load_test.dart File test/runner/pause_after_load_test.dart (right): https://codereview.chromium.org/1263593005/diff/1/test/runner/pause_after_load_test.dart#newcode249 test/runner/pause_after_load_test.dart:249: var test = runTest( On 2015/07/28 22:43:56, kevmoo wrote: ...

5 years, 4 months ago (2015-07-29 00:33:01 UTC) #3

nweiz

5 years, 4 months ago (2015-07-29 00:33:56 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
4811a3fd06224bb2c5c44f73a985eeb422154ee5 (presubmit successful).

Expand Messages | Collapse Messages