Issue 1263573010: Use zone when allocating handles in FlowGraphCompiler assembling operations. Add profiling VM tags…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1263573010: Use zone when allocating handles in FlowGraphCompiler assembling operations. Add profiling VM tags… (Closed)

Created:
5 years, 4 months ago by srdjan

Modified:
5 years, 4 months ago

Reviewers:
regis

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
https://github.com/dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Use zone when allocating handles in FlowGraphCompiler assembling operations. Add profiling VM tags for parse and flow graph builder, active only when --profile_vm. Lazily generate IR constant_value handles. BUG= R=regis@google.com Committed: https://github.com/dart-lang/sdk/commit/1a1ff00a29f7befdb9065cf2a9504c0c172b1cc6

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+264 lines, -213 lines)			Patch
M	runtime/vm/constant_propagator.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	runtime/vm/flow_graph_builder.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm.cc	View	22 chunks	+46 lines, -42 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_arm64.cc	View	22 chunks	+46 lines, -42 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_ia32.cc	View	21 chunks	+42 lines, -38 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_mips.cc	View	22 chunks	+50 lines, -42 lines	0 comments	Download
M	runtime/vm/flow_graph_compiler_x64.cc	View	23 chunks	+46 lines, -42 lines	0 comments	Download
M	runtime/vm/intermediate_language.h	View	2 chunks	+2 lines, -2 lines	0 comments	Download
M	runtime/vm/intermediate_language.cc	View	1 chunk	+13 lines, -1 line	0 comments	Download
M	runtime/vm/parser.cc	View	2 chunks	+4 lines, -0 lines	0 comments	Download
M	runtime/vm/regexp_parser.cc	View	1 chunk	+2 lines, -0 lines	0 comments	Download
M	runtime/vm/tags.h	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	runtime/vm/tags.cc	View	1 chunk	+4 lines, -2 lines	0 comments	Download

Total messages: 4 (1 generated)

srdjan

5 years, 4 months ago (2015-08-03 17:11:45 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
1a1ff00a29f7befdb9065cf2a9504c0c172b1cc6 (presubmit successful).