Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 1263443005: Make exclude list also exclude contexts (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make exclude list also exclude contexts - Only create a context if the directory/.packages/pubspec.yaml is not excluded. - Add tests. Fixes: https://github.com/dart-lang/sdk/issues/23941 R=brianwilkerson@google.com, devoncarew@google.com, paulberry@google.com, pquitslund@google.com Committed: https://github.com/dart-lang/sdk/commit/dfc35faaf940cc16c5d121e547d2c79c53cf1813

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+110 lines, -5 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 3 chunks +11 lines, -5 lines 0 comments Download
M pkg/analysis_server/test/context_manager_test.dart View 1 chunk +90 lines, -0 lines 0 comments Download
M pkg/analyzer/lib/source/path_filter.dart View 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Cutch
5 years, 4 months ago (2015-08-03 13:39:14 UTC) #2
devoncarew
lgtm Lgtm, but should also get a review from someone more familiar with this code. ...
5 years, 4 months ago (2015-08-03 20:06:49 UTC) #4
Brian Wilkerson
I added Paul because he's making changes in this same area and I want to ...
5 years, 4 months ago (2015-08-03 20:09:27 UTC) #6
Paul Berry
lgtm
5 years, 4 months ago (2015-08-03 20:49:05 UTC) #7
pquitslund
LGTM!
5 years, 4 months ago (2015-08-03 20:54:05 UTC) #8
Cutch
5 years, 4 months ago (2015-08-03 20:54:25 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
dfc35faaf940cc16c5d121e547d2c79c53cf1813 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698