Issue 1263323003: Fix use-after-free from my previous CL.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1263323003: Fix use-after-free from my previous CL. (Closed)

Created:
5 years, 4 months ago by Florian Schneider

Modified:
5 years, 4 months ago

Reviewers:
koda

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Fix use-after-free from my previous CL. The destructor of Metric must be invoked on a running isolate (i.e. before shutting down the isolate.) BUG= R=koda@google.com Committed: https://github.com/dart-lang/sdk/commit/e1468b54a3f88295f59463c00d9a418cf7dd324b

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -8 lines)			Patch
	M	runtime/vm/metrics_test.cc	View		1 chunk	+10 lines, -8 lines	0 comments	Download

Total messages: 5 (1 generated)

koda

LGTM ... but why can't this test case simply use TEST_CASE instead (which handles isolate ...

5 years, 4 months ago (2015-08-03 15:32:20 UTC) #3

Florian Schneider

On 2015/08/03 15:32:20, koda wrote: > LGTM > > ... but why can't this test ...

5 years, 4 months ago (2015-08-03 15:34:14 UTC) #4

Florian Schneider

5 years, 4 months ago (2015-08-03 15:34:36 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e1468b54a3f88295f59463c00d9a418cf7dd324b (presubmit successful).