Add a SafeHttpServer shim to work around issue 9140.

Add a SafeHttpServer shim to work around issue 9140.

Committed: https://code.google.com/p/dart/source/detail?r=20054

[Bob Nystrom, 2013-03-14 20:41:51]

I just review the SafeHttpServer stuff. The other changes are the same from the
ScheduledServer patch, right?

Couple of nits but LGTM.

https://codereview.chromium.org/12633015/diff/1/pkg/http/test/safe_http_serve...
File pkg/http/test/safe_http_server.dart (right):

https://codereview.chromium.org/12633015/diff/1/pkg/http/test/safe_http_serve...
pkg/http/test/safe_http_server.dart:5: library safe_http_server;
Maybe put this in http/lib/temp/safe_http_server.dart or something like that so
that pub can import it from there instead of having to have two copies of this?

https://codereview.chromium.org/12633015/diff/1/pkg/http/test/safe_http_serve...
pkg/http/test/safe_http_server.dart:55: if (error is SocketIOException &&
error.osError.errorCode == 104) return;
Is this the same error code on Windows, Mac, and Linux?

[nweiz, 2013-03-14 22:12:00]

https://codereview.chromium.org/12633015/diff/1/pkg/http/test/safe_http_serve...
File pkg/http/test/safe_http_server.dart (right):

https://codereview.chromium.org/12633015/diff/1/pkg/http/test/safe_http_serve...
pkg/http/test/safe_http_server.dart:5: library safe_http_server;
On 2013/03/14 20:41:51, Bob Nystrom wrote:
> Maybe put this in http/lib/temp/safe_http_server.dart or something like that
so
> that pub can import it from there instead of having to have two copies of
this?

There are three copies; I also put it in scheduled_test.

I don't really feel too bad about copying it, given that it should go away
pretty soon. Also, I don't want a non-dev dependency between scheduled_test and
http.

https://codereview.chromium.org/12633015/diff/1/pkg/http/test/safe_http_serve...
pkg/http/test/safe_http_server.dart:55: if (error is SocketIOException &&
error.osError.errorCode == 104) return;
On 2013/03/14 20:41:51, Bob Nystrom wrote:
> Is this the same error code on Windows, Mac, and Linux?

Preliminary results indicate this doesn't reproduce on Mac. We'll see how
Windows does on the buildbots.

[nweiz, 2013-03-14 22:12:29]

Committed patchset #1 manually as r20054 (presubmit successful).