Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 1263093003: include exported library namespace in prefixed import suggestions (Closed)

Created:
5 years, 4 months ago by danrubel
Modified:
5 years, 4 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

include exported library namespace in prefixed import suggestions Closes #23946 R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/9d5154a1fdd5b20c9652a923fcf8c4f30e53bb49

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -0 lines) Patch
M pkg/analysis_server/lib/src/services/completion/suggestion_builder.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analysis_server/test/services/completion/prefixed_element_contributor_test.dart View 1 chunk +11 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
danrubel
5 years, 4 months ago (2015-08-03 05:57:55 UTC) #2
Brian Wilkerson
LGTM
5 years, 4 months ago (2015-08-03 13:47:29 UTC) #3
danrubel
5 years, 4 months ago (2015-08-03 20:52:50 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
9d5154a1fdd5b20c9652a923fcf8c4f30e53bb49 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698