Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(38)

Issue 12629004: Implement native call stub on ARM and native call redirection in ARM simulator. (Closed)

Created:
7 years, 9 months ago by regis
Modified:
7 years, 9 months ago
Reviewers:
zra, siva, Ivan Posva
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Implement native call stub on ARM and native call redirection in ARM simulator. Pass PatchStaticCall test. Committed: https://code.google.com/p/dart/source/detail?r=19704

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+162 lines, -39 lines) Patch
M runtime/tests/vm/vm.status View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/assembler_arm.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M runtime/vm/assembler_arm.cc View 1 3 chunks +8 lines, -2 lines 0 comments Download
M runtime/vm/flow_graph_compiler_arm.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M runtime/vm/intermediate_language_arm.cc View 1 2 chunks +37 lines, -3 lines 0 comments Download
M runtime/vm/runtime_entry_arm.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M runtime/vm/simulator_arm.h View 1 1 chunk +6 lines, -3 lines 0 comments Download
M runtime/vm/simulator_arm.cc View 1 5 chunks +31 lines, -26 lines 0 comments Download
M runtime/vm/stub_code_arm.cc View 1 3 chunks +75 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
regis
I have looked at changing Dart API native calls to accept a NativeArguments by value ...
7 years, 9 months ago (2013-03-07 21:58:56 UTC) #1
zra
https://codereview.chromium.org/12629004/diff/1/runtime/vm/os_android.cc File runtime/vm/os_android.cc (right): https://codereview.chromium.org/12629004/diff/1/runtime/vm/os_android.cc#newcode392 runtime/vm/os_android.cc:392: // Passing -export-dynamic to the linker does not help. ...
7 years, 9 months ago (2013-03-08 16:55:42 UTC) #2
Ivan Posva
DBC -ip https://codereview.chromium.org/12629004/diff/1/runtime/vm/os_linux.cc File runtime/vm/os_linux.cc (right): https://codereview.chromium.org/12629004/diff/1/runtime/vm/os_linux.cc#newcode490 runtime/vm/os_linux.cc:490: if (dladdr(reinterpret_cast<void*>(address), &info)) { I am not ...
7 years, 9 months ago (2013-03-08 17:00:42 UTC) #3
regis
On 2013/03/08 17:00:42, Ivan Posva wrote: > DBC -ip > > https://codereview.chromium.org/12629004/diff/1/runtime/vm/os_linux.cc > File runtime/vm/os_linux.cc ...
7 years, 9 months ago (2013-03-08 17:46:21 UTC) #4
zra
lgtm
7 years, 9 months ago (2013-03-08 18:19:16 UTC) #5
regis
7 years, 9 months ago (2013-03-08 18:22:21 UTC) #6
Message was sent while issue was closed.
Committed patchset #2 manually as r19704 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698