Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(496)

Issue 1262623006: Temporarily bring in code from the async package. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
kevmoo
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/test@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Temporarily bring in code from the async package. StreamQueue.fork and CancelableFuture will (hopefully) land in async, but we're putting them here for now to avoid being blocked. R=kevmoo@google.com Committed: https://github.com/dart-lang/test/commit/13cee2cd2f64b1fbe119f63cb284bcdd106d7d96

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+2890 lines, -0 lines) Patch
A lib/src/util/cancelable_future.dart View 1 chunk +217 lines, -0 lines 2 comments Download
A lib/src/util/forkable_stream.dart View 1 chunk +168 lines, -0 lines 0 comments Download
A lib/src/util/stream_queue.dart View 1 chunk +699 lines, -0 lines 0 comments Download
A test/util/cancelable_future_test.dart View 1 chunk +255 lines, -0 lines 0 comments Download
A test/util/forkable_stream_test.dart View 1 chunk +417 lines, -0 lines 0 comments Download
A test/util/stream_queue_test.dart View 1 chunk +1134 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
nweiz
5 years, 4 months ago (2015-07-29 22:30:17 UTC) #1
kevmoo
lgtm https://codereview.chromium.org/1262623006/diff/1/lib/src/util/cancelable_future.dart File lib/src/util/cancelable_future.dart (right): https://codereview.chromium.org/1262623006/diff/1/lib/src/util/cancelable_future.dart#newcode87 lib/src/util/cancelable_future.dart:87: CancelableFuture catchError(Function onError, {bool test(error)}) => docs for ...
5 years, 4 months ago (2015-07-29 23:03:46 UTC) #2
nweiz
https://codereview.chromium.org/1262623006/diff/1/lib/src/util/cancelable_future.dart File lib/src/util/cancelable_future.dart (right): https://codereview.chromium.org/1262623006/diff/1/lib/src/util/cancelable_future.dart#newcode87 lib/src/util/cancelable_future.dart:87: CancelableFuture catchError(Function onError, {bool test(error)}) => On 2015/07/29 23:03:46, ...
5 years, 4 months ago (2015-07-29 23:18:10 UTC) #3
nweiz
5 years, 4 months ago (2015-07-29 23:18:30 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
13cee2cd2f64b1fbe119f63cb284bcdd106d7d96 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698