Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 1262483002: Fix a deadlock. (Closed)

Created:
5 years, 4 months ago by nweiz
Modified:
5 years, 4 months ago
Reviewers:
Bob Nystrom
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/barback@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix a deadlock. Closes #64 See dart-lang/pub#1306, dart-lang/test#303 R=rnystrom@google.com Committed: https://github.com/dart-lang/barback/commit/edb5bf9d06c007b36fd8f6237818a094183e8ee7

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+46 lines, -1 line) Patch
M CHANGELOG.md View 1 chunk +5 lines, -0 lines 0 comments Download
M lib/src/graph/transform_node.dart View 2 chunks +11 lines, -0 lines 0 comments Download
M pubspec.yaml View 1 chunk +1 line, -1 line 0 comments Download
M test/package_graph/declaring_transformer_test.dart View 1 chunk +29 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
nweiz
5 years, 4 months ago (2015-07-27 21:01:39 UTC) #1
Bob Nystrom
lgtm
5 years, 4 months ago (2015-07-27 21:18:08 UTC) #2
nweiz
5 years, 4 months ago (2015-07-27 21:36:10 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
edb5bf9d06c007b36fd8f6237818a094183e8ee7 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698