Handle super index SendSet operations.

Handle super index SendSet operations.

BUG=
R=floitsch@google.com

Committed: https://github.com/dart-lang/sdk/commit/0a1b5dfbefc9a589c1b31f796fc0e6bd53de6071

[Johnni Winther, 2015-07-30 13:40:13]

johnniwinther@google.com changed reviewers:
+ floitsch@google.com

[Johnni Winther, 2015-07-31 10:55:28]

ping

[floitsch, 2015-07-31 12:30:37]

LGTM.

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:967: } else {
Maybe add a short comment, explaining why it's not possible to have anything
else here.
Basically:
// Either the field is accessible directly, or a setter shadows the setter
access. If there was another instance member it would shadow the field.

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:1154: // call
[:super.noSuchMethod:] which calls [JSInvocationMirror._invokeOn].
nit. I prefer `super.noSuchMethod`.

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/semantic_visitor.dart (right):

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:4142: ///   m() => ~super;
why is this invalid?

Code samples should be intended by 4, and must have a new line before them.

[Johnni Winther, 2015-07-31 13:38:29]

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/members.dart (right):

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:967: } else {
On 2015/07/31 12:30:37, floitsch wrote:
> Maybe add a short comment, explaining why it's not possible to have anything
> else here.
> Basically:
> // Either the field is accessible directly, or a setter shadows the setter
> access. If there was another instance member it would shadow the field.

Done.

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/members.dart:1154: // call
[:super.noSuchMethod:] which calls [JSInvocationMirror._invokeOn].
On 2015/07/31 12:30:37, floitsch wrote:
> nit. I prefer `super.noSuchMethod`.

Done.

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
File pkg/compiler/lib/src/resolution/semantic_visitor.dart (right):

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:4142: ///   m() => ~super;
On 2015/07/31 12:30:37, floitsch wrote:
> why is this invalid?
> 
> Code samples should be intended by 4, and must have a new line before them.

It is top level. Changing the examples to be static instead.

https://codereview.chromium.org/1262363003/diff/20001/pkg/compiler/lib/src/re...
pkg/compiler/lib/src/resolution/semantic_visitor.dart:4142: ///   m() => ~super;
On 2015/07/31 12:30:37, floitsch wrote:
> why is this invalid?
> 
> Code samples should be intended by 4, and must have a new line before them.

Done.

[Johnni Winther, 2015-07-31 13:42:15]

Committed patchset #3 (id:40001) manually as
0a1b5dfbefc9a589c1b31f796fc0e6bd53de6071 (presubmit successful).