Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(216)

Issue 1262163002: Implement DEP 34 (less restricted mixins) in analysis engine. (Closed)

Created:
5 years, 4 months ago by Paul Berry
Modified:
5 years, 4 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Implement DEP 34 (less restricted mixins) in analysis engine. The feature is disabled by default; enable it by setting the option "enableSuperMixins". (This name was chosen to match the "--supermixin" flag accepted by the VM). The feature is not yet exposed through analysis server or the analyzer_cli. R=scheglov@google.com Committed: https://github.com/dart-lang/sdk/commit/fcfea00af83d4cff4abc7d533c1ca65f818dba1d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -14 lines) Patch
M pkg/analyzer/lib/src/context/context.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/generated/engine.dart View 8 chunks +23 lines, -4 lines 0 comments Download
M pkg/analyzer/lib/src/generated/error_verifier.dart View 3 chunks +10 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/src/generated/incremental_resolver.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/lib/src/task/dart.dart View 1 chunk +2 lines, -1 line 0 comments Download
M pkg/analyzer/test/generated/engine_test.dart View 4 chunks +13 lines, -4 lines 0 comments Download
M pkg/analyzer/test/generated/non_error_resolver_test.dart View 4 chunks +67 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Paul Berry
5 years, 4 months ago (2015-07-29 15:41:05 UTC) #2
scheglov
LGTM
5 years, 4 months ago (2015-07-29 15:47:00 UTC) #3
Paul Berry
5 years, 4 months ago (2015-07-29 15:50:53 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
fcfea00af83d4cff4abc7d533c1ca65f818dba1d (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698