Issue 12620002: Emit compile time error on static non-members.

Issue 12620002: Emit compile time error on static non-members. (Closed)

Created:
7 years, 9 months ago by karlklose

Modified:
7 years, 9 months ago

Reviewers:
Johnni Winther

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Emit compile time error on static non-members. BUG=dartbug.com/1018 Committed: https://code.google.com/p/dart/source/detail?r=19671

Patch Set 2 : Adjust test expectations. #

Total comments: 2

Patch Set 3 : Reword warning and move it before the crash messages. #

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -3 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/resolution/members.dart	View	1	1 chunk	+6 lines, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/warnings.dart	View	1 2	1 chunk	+4 lines, -0 lines	0 comments	Download
M	tests/co19/co19-dart2js.status	View	1	1 chunk	+0 lines, -2 lines	0 comments	Download

Messages

Total messages: 5 (0 generated)

Expand Messages | Collapse Messages

Johnni Winther

lgtm https://codereview.chromium.org/12620002/diff/2001/sdk/lib/_internal/compiler/implementation/warnings.dart File sdk/lib/_internal/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/12620002/diff/2001/sdk/lib/_internal/compiler/implementation/warnings.dart#newcode396 sdk/lib/_internal/compiler/implementation/warnings.dart:396: "Error: Static is only allowed on functions declared ...

7 years, 9 months ago (2013-03-07 17:39:51 UTC) #3

karlklose

Thanks, Johnni and Peter. https://codereview.chromium.org/12620002/diff/2001/sdk/lib/_internal/compiler/implementation/warnings.dart File sdk/lib/_internal/compiler/implementation/warnings.dart (right): https://codereview.chromium.org/12620002/diff/2001/sdk/lib/_internal/compiler/implementation/warnings.dart#newcode396 sdk/lib/_internal/compiler/implementation/warnings.dart:396: "Error: Static is only allowed ...

7 years, 9 months ago (2013-03-08 09:15:00 UTC) #4

karlklose

7 years, 9 months ago (2013-03-08 09:15:19 UTC) #5

Message was sent while issue was closed.

Committed patchset #3 manually as r19671 (presubmit successful).

Expand Messages | Collapse Messages