Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1261923008: Begin migration of InterruptableThreadState into Thread. (Closed)

Created:
5 years, 4 months ago by koda
Modified:
5 years, 4 months ago
Reviewers:
Cutch
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Begin migration of InterruptableThreadState into Thread. Move the field from Isolate to Thread::state_ to allow using a single thread local key. Profiling is still only enabled for the Dart mutator thread. The next step is to migrate the VM tags. BUG= R=johnmccutchan@google.com Committed: https://github.com/dart-lang/sdk/commit/df448e21dac3dad2176295c5906c5d453ec09390

Patch Set 1 #

Patch Set 2 : Fixes. #

Patch Set 3 : Update test. #

Total comments: 1

Patch Set 4 : Parentheses. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -27 lines) Patch
M runtime/vm/isolate.h View 1 2 3 2 chunks +1 line, -7 lines 0 comments Download
M runtime/vm/isolate.cc View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/thread.h View 1 3 chunks +12 lines, -0 lines 0 comments Download
M runtime/vm/thread.cc View 1 2 5 chunks +7 lines, -6 lines 0 comments Download
M runtime/vm/thread_interrupter.h View 1 1 chunk +0 lines, -1 line 0 comments Download
M runtime/vm/thread_interrupter.cc View 1 2 chunks +2 lines, -10 lines 0 comments Download
M runtime/vm/thread_test.cc View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
koda
5 years, 4 months ago (2015-08-04 02:24:30 UTC) #2
Cutch
lgtm https://codereview.chromium.org/1261923008/diff/40001/runtime/vm/isolate.h File runtime/vm/isolate.h (right): https://codereview.chromium.org/1261923008/diff/40001/runtime/vm/isolate.h#newcode637 runtime/vm/isolate.h:637: return mutator_thread_ == NULL ? NULL : mutator_thread_->thread_state(); ...
5 years, 4 months ago (2015-08-04 13:02:29 UTC) #3
koda
On 2015/08/04 13:02:29, Cutch wrote: > lgtm > > https://codereview.chromium.org/1261923008/diff/40001/runtime/vm/isolate.h > File runtime/vm/isolate.h (right): > ...
5 years, 4 months ago (2015-08-05 00:50:45 UTC) #4
koda
Committed patchset #4 (id:50008) manually as df448e21dac3dad2176295c5906c5d453ec09390 (presubmit successful).
5 years, 4 months ago (2015-08-07 17:29:01 UTC) #5
kevmoo
5 years, 4 months ago (2015-08-07 19:01:42 UTC) #6
Message was sent while issue was closed.
On 2015/08/07 17:29:01, koda wrote:
> Committed patchset #4 (id:50008) manually as
> df448e21dac3dad2176295c5906c5d453ec09390 (presubmit successful).

Looks like a couple of files snuck in accidentally: perf.data and perf.data.old

Powered by Google App Engine
This is Rietveld 408576698