Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(273)

Issue 12618010: Rename the name of the new analyzer jar file from new_analyzer.jar to (Closed)

Created:
7 years, 9 months ago by devoncarew
Modified:
7 years, 8 months ago
Reviewers:
ricow1, ahe, Brian Wilkerson
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Rename the name of the new analyzer jar file from new_analyzer.jar to dartanalyzer.jar (which I think will be the preferred name for it in the SDK). Update the test framework for these renames. Committed: https://code.google.com/p/dart/source/detail?r=20994

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -86 lines) Patch
M editor/analyzer.gyp View 1 2 2 chunks +1 line, -3 lines 0 comments Download
D sdk/bin/analyzer View 1 2 1 chunk +0 lines, -41 lines 0 comments Download
D sdk/bin/analyzer.bat View 1 2 1 chunk +0 lines, -27 lines 0 comments Download
A + sdk/bin/dartanalyzer View 1 chunk +3 lines, -3 lines 0 comments Download
A + sdk/bin/dartanalyzer.bat View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/testing/dart/test_options.dart View 1 2 3 chunks +4 lines, -4 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 1 2 5 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
devoncarew
7 years, 9 months ago (2013-03-21 01:10:18 UTC) #1
ahe
Generally, I think you need to move away from ANT. We already have a build ...
7 years, 9 months ago (2013-03-21 05:27:46 UTC) #2
ricow1
The renaming lgtm I do agree with Peter about ANT though, what is it that ...
7 years, 9 months ago (2013-03-21 07:09:27 UTC) #3
Brian Wilkerson
The name change is fine, but I can't speak to the rest.
7 years, 9 months ago (2013-03-21 22:18:05 UTC) #4
devoncarew
Thanks for the reviews. It sounds like we're good with the rename in general, good ...
7 years, 9 months ago (2013-03-22 23:12:01 UTC) #5
devoncarew
I've updated this CL to not use ant so I can make progress on getting ...
7 years, 8 months ago (2013-04-05 16:43:41 UTC) #6
ahe
lgtm
7 years, 8 months ago (2013-04-05 16:45:14 UTC) #7
devoncarew
7 years, 8 months ago (2013-04-05 19:33:31 UTC) #8
Message was sent while issue was closed.
Committed patchset #3 manually as r20994 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698