Issue 12617002: dart:io | Implement FileSystemEntity.typeSync on Windows, to identify symbolic links and junctions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12617002: dart:io | Implement FileSystemEntity.typeSync on Windows, to identify symbolic links and junctions. (Closed)

Created:
7 years, 9 months ago by Bill Hesse

Modified:
7 years, 9 months ago

Reviewers:
Bob Nystrom, Søren Gjesse

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

dart:io | Implement FileSystemEntity.typeSync on Windows, to identify symbolic links and junctions. BUG=dartbug.com/8935 Committed: https://code.google.com/p/dart/source/detail?r=19681

Patch Set 2 : Make new test a no-op on non-windows platforms. #

Total comments: 1

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+105 lines, -1 line)			Patch
	M	runtime/bin/file_win.cc	View		1 chunk	+21 lines, -1 line	0 comments	Download
	A	tests/standalone/io/windows_file_system_links_test.dart	View	1	1 chunk	+84 lines, -0 lines	1 comment	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Søren Gjesse

lgtm https://codereview.chromium.org/12617002/diff/2001/tests/standalone/io/windows_file_system_links_test.dart File tests/standalone/io/windows_file_system_links_test.dart (right): https://codereview.chromium.org/12617002/diff/2001/tests/standalone/io/windows_file_system_links_test.dart#newcode47 tests/standalone/io/windows_file_system_links_test.dart:47: Expect.equals(FileSystemEntityType.DIRECTORY, FileSystemEntity.typeSync(y)); Long line (two more below).

7 years, 9 months ago (2013-03-08 09:38:50 UTC) #2

Message was sent while issue was closed.

LGTM!

Expand Messages | Collapse Messages

Issue 12617002: dart:io | Implement FileSystemEntity.typeSync on Windows, to identify symbolic links and junctions. (Closed)

Description

Patch Set 1 #

Patch Set 2 : Make new test a no-op on non-windows platforms. #

Messages