Non-tree-shaking --precompile.

Non-tree-shaking --precompile.

R=srdjan@google.com

Committed: https://github.com/dart-lang/sdk/commit/8a3e1345024648861b26f634a944f0811b418319

[rmacnak, 2015-07-29 19:30:37]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, srdjan@google.com

[rmacnak, 2015-07-29 19:30:39]

About 1% of language tests still failing with --precompile, mostly related to
const.

hello world has a 40 MB heap.

https://codereview.chromium.org/1261673004/diff/20001/runtime/vm/flow_graph_t...
File runtime/vm/flow_graph_type_propagator.cc (right):

https://codereview.chromium.org/1261673004/diff/20001/runtime/vm/flow_graph_t...
runtime/vm/flow_graph_type_propagator.cc:1041: if
(Isolate::Current()->flags().type_checks() &&
First closurization of methods in TwoByteString etc

https://codereview.chromium.org/1261673004/diff/20001/runtime/vm/parser.cc
File runtime/vm/parser.cc (left):

https://codereview.chromium.org/1261673004/diff/20001/runtime/vm/parser.cc#ol...
runtime/vm/parser.cc:1062: ASSERT(field.value() ==
Object::transition_sentinel().raw());
Now we sometimes create an initializer for a field that was already initialized.

[rmacnak, 2015-07-29 20:53:08]

Nvm, was closurizing way too much. hello world is 23 MB heap.

[srdjan, 2015-07-29 21:39:13]

https://codereview.chromium.org/1261673004/diff/60001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1261673004/diff/60001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1269: false,
describe/comment what argument false is assigned to.

https://codereview.chromium.org/1261673004/diff/60001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1286: if (initializer.IsNull()) {
Please describe what is going on (when can field.initializer be non-null). Who
sets field.initializer?

https://codereview.chromium.org/1261673004/diff/60001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1290: Parser::ParseStaticFieldInitializer(field);
4 spaces indent.

https://codereview.chromium.org/1261673004/diff/60001/runtime/vm/isolate.h
File runtime/vm/isolate.h (right):

https://codereview.chromium.org/1261673004/diff/60001/runtime/vm/isolate.h#ne...
runtime/vm/isolate.h:715: bool compilation_allowed() { return
compilation_allowed_; }
const

[rmacnak, 2015-07-29 23:09:28]

https://codereview.chromium.org/1261673004/diff/60001/runtime/vm/compiler.cc
File runtime/vm/compiler.cc (right):

https://codereview.chromium.org/1261673004/diff/60001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1269: false,
On 2015/07/29 21:39:13, srdjan wrote:
> describe/comment what argument false is assigned to.

Done.

https://codereview.chromium.org/1261673004/diff/60001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1286: if (initializer.IsNull()) {
On 2015/07/29 21:39:13, srdjan wrote:
> Please describe what is going on (when can field.initializer be non-null). Who
> sets field.initializer?

Done.

https://codereview.chromium.org/1261673004/diff/60001/runtime/vm/compiler.cc#...
runtime/vm/compiler.cc:1290: Parser::ParseStaticFieldInitializer(field);
On 2015/07/29 21:39:13, srdjan wrote:
> 4 spaces indent.

Done.

[srdjan, 2015-07-30 20:25:41]

LGTM

[rmacnak, 2015-07-30 22:29:24]

Committed patchset #5 (id:80001) manually as
8a3e1345024648861b26f634a944f0811b418319 (presubmit successful).