Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 1261623002: Add AccessSemantics.INVALID for invalid expressions. (Closed)

Created:
5 years, 4 months ago by Johnni Winther
Modified:
5 years, 4 months ago
Reviewers:
herhut
CC:
reviews_dartlang.org, Anders Johnsen
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add AccessSemantics.INVALID for invalid expressions. BUG= R=herhut@google.com Committed: https://github.com/dart-lang/sdk/commit/31a62b55050840d941dac071e7bf15460685a021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+401 lines, -50 lines) Patch
M pkg/compiler/lib/src/cps_ir/cps_ir_builder_task.dart View 5 chunks +5 lines, -34 lines 0 comments Download
M pkg/compiler/lib/src/resolution/access_semantics.dart View 2 chunks +7 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/members.dart View 2 chunks +7 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor.dart View 1 chunk +80 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolution/semantic_visitor_mixins.dart View 6 chunks +120 lines, -5 lines 0 comments Download
M pkg/compiler/lib/src/resolution/send_structure.dart View 6 chunks +37 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/resolved_visitor.dart View 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/ssa/builder.dart View 2 chunks +8 lines, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test.dart View 5 chunks +18 lines, -1 line 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_data.dart View 3 chunks +47 lines, -2 lines 0 comments Download
M tests/compiler/dart2js/semantic_visitor_test_send_visitor.dart View 1 chunk +67 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Johnni Winther
5 years, 4 months ago (2015-07-27 12:12:37 UTC) #2
herhut
lgtm
5 years, 4 months ago (2015-07-29 08:05:09 UTC) #3
Johnni Winther
5 years, 4 months ago (2015-07-29 08:26:49 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
31a62b55050840d941dac071e7bf15460685a021 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698