Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 12615002: Remove references to capital-D-Dynamic. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Remove references to capital-D-Dynamic. Committed: https://code.google.com/p/dart/source/detail?r=19687

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+31 lines, -36 lines) Patch
M runtime/lib/mirrors_impl.dart View 3 chunks +3 lines, -4 lines 0 comments Download
M runtime/tests/vm/dart/isolate_mirror_local_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/isolate_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/lib/js_helper.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/_internal/compiler/implementation/resolution/members.dart View 1 chunk +0 lines, -4 lines 0 comments Download
M sdk/lib/_internal/compiler/implementation/types/simple_types_inferrer.dart View 5 chunks +5 lines, -5 lines 0 comments Download
M sdk/lib/_internal/dartdoc/lib/dartdoc.dart View 2 chunks +2 lines, -2 lines 1 comment Download
M tests/compiler/dart2js/mirrors_test.dart View 6 chunks +11 lines, -11 lines 0 comments Download
M tests/corelib/collection_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.textmate View 1 chunk +1 line, -1 line 0 comments Download
M tools/utils/textmate/Dart.tmbundle/Syntaxes/Dart.tmLanguage View 1 chunk +1 line, -1 line 0 comments Download
M utils/template/htmltree.dart View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Lasse Reichstein Nielsen
The only real change is in Mirrors.
7 years, 9 months ago (2013-03-07 17:31:02 UTC) #1
Johnni Winther
lgtm https://codereview.chromium.org/12615002/diff/1/sdk/lib/_internal/dartdoc/lib/dartdoc.dart File sdk/lib/_internal/dartdoc/lib/dartdoc.dart (right): https://codereview.chromium.org/12615002/diff/1/sdk/lib/_internal/dartdoc/lib/dartdoc.dart#newcode1674 sdk/lib/_internal/dartdoc/lib/dartdoc.dart:1674: // Don't bother explicitly displaying Ddnamic. Ddnamic -> ...
7 years, 9 months ago (2013-03-07 17:37:20 UTC) #2
Lasse Reichstein Nielsen
7 years, 9 months ago (2013-03-08 11:57:40 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19687 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698