Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(196)

Issue 1261483003: Stop sniffing user agent in vm service http server (Closed)

Created:
5 years, 4 months ago by Cutch
Modified:
5 years, 4 months ago
CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Stop sniffing user agent in vm service http server - We don't need this check anymore. - Removing it fixes an issue with uberproxy. R=sigmund@google.com Committed: https://github.com/dart-lang/sdk/commit/67b480ee0d142b4f105bba44ef0a0c7ef0ad3e95

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -19 lines) Patch
M runtime/bin/vmservice/server.dart View 2 chunks +0 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Cutch
5 years, 4 months ago (2015-07-30 23:57:57 UTC) #2
Siggi Cherem (dart-lang)
lgtm
5 years, 4 months ago (2015-07-31 00:05:44 UTC) #4
Cutch
5 years, 4 months ago (2015-07-31 19:21:00 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
67b480ee0d142b4f105bba44ef0a0c7ef0ad3e95 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698