Add setNoDelay method on Socket/RawSocket.

Add setOption method on Socket/RawSocket.

This will allow the user to enable TCP_NODELAY on the native sockets.

BUG=

Committed: https://code.google.com/p/dart/source/detail?r=20014

[Søren Gjesse, 2013-03-14 11:28:40]

Looks af if you are missing Android

https://codereview.chromium.org/12614014/diff/1/sdk/lib/io/socket.dart
File sdk/lib/io/socket.dart (right):

https://codereview.chromium.org/12614014/diff/1/sdk/lib/io/socket.dart#newcod...
sdk/lib/io/socket.dart:190: bool setNoDelay([bool enabled = true]);
Wondering whether this should be a setter instead

Socket s = ...
s.tcpNoDelay = true;

or we should have a more general way of setting options

Socket s = ...
s.setOption(Socket.TCP_NODELAY, true);

[Anders Johnsen, 2013-03-14 11:56:25]

PTAL

[Søren Gjesse, 2013-03-14 12:39:59]

LGTM if you update socket_android.cc as well

https://codereview.chromium.org/12614014/diff/7001/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://codereview.chromium.org/12614014/diff/7001/runtime/bin/socket.cc#newc...
runtime/bin/socket.cc:453: Dart_Handle err =
Socket::GetSocketIdNativeField(socket_obj, &socket);
Use

if (Dart_IsError(err)) Dart_PropagateError(err)

here.

https://codereview.chromium.org/12614014/diff/7001/runtime/bin/socket.cc#newc...
runtime/bin/socket.cc:457: err = Dart_IntegerToInt64(option_obj, &option);
And here.

[Anders Johnsen, 2013-03-14 12:45:05]

Added for android as well, landing.

https://codereview.chromium.org/12614014/diff/7001/runtime/bin/socket.cc
File runtime/bin/socket.cc (right):

https://codereview.chromium.org/12614014/diff/7001/runtime/bin/socket.cc#newc...
runtime/bin/socket.cc:453: Dart_Handle err =
Socket::GetSocketIdNativeField(socket_obj, &socket);
On 2013/03/14 12:39:59, Søren Gjesse wrote:
> Use
> 
> if (Dart_IsError(err)) Dart_PropagateError(err)
> 
> here.

Done.

https://codereview.chromium.org/12614014/diff/7001/runtime/bin/socket.cc#newc...
runtime/bin/socket.cc:457: err = Dart_IntegerToInt64(option_obj, &option);
On 2013/03/14 12:39:59, Søren Gjesse wrote:
> And here.

Done.

[Anders Johnsen, 2013-03-14 12:47:11]

Committed patchset #4 manually as r20014 (presubmit successful).