Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(24)

Issue 12613008: Remove pkg from apidoc. (Closed)

Created:
7 years, 9 months ago by Johnni Winther
Modified:
7 years, 9 months ago
Reviewers:
bakster
CC:
reviews_dartlang.org, Andrei Mouravski
Visibility:
Public.

Description

Remove pkg from apidoc. Committed: https://code.google.com/p/dart/source/detail?r=19636

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+28 lines, -66 lines) Patch
M sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart View 2 chunks +4 lines, -4 lines 1 comment Download
M utils/apidoc/apidoc.dart View 1 chunk +23 lines, -53 lines 0 comments Download
M utils/apidoc/apidoc.gyp View 1 chunk +1 line, -9 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Johnni Winther
https://codereview.chromium.org/12613008/diff/1/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart File sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart (right): https://codereview.chromium.org/12613008/diff/1/sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart#newcode219 sdk/lib/_internal/compiler/implementation/mirrors/dart2js_mirror.dart:219: Uri libraryUri = cwd.resolve(appendSlash(libraryRoot.toString())); This appends a slash only ...
7 years, 9 months ago (2013-03-07 14:51:57 UTC) #1
bakster
LGTM
7 years, 9 months ago (2013-03-07 14:59:00 UTC) #2
Johnni Winther
7 years, 9 months ago (2013-03-07 15:02:04 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19636 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698