Issue 1261203005: Revert "Change `msg` to `message` in debugger function."

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1261203005: Revert "Change `msg` to `message` in debugger function." (Closed)

Created:
5 years, 4 months ago by Bill Hesse

Modified:
5 years, 4 months ago

Reviewers:
Lasse Reichstein Nielsen

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Revert "Change `msg` to `message` in debugger function." This reverts commit 2ae214316c61a6c3a4f80e81b8ed1748c65abc07. BUG= Committed: https://github.com/dart-lang/sdk/commit/bdda0eff52d04bbaabfb66ef335276966a27d8ef

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -11 lines)			Patch
M	runtime/lib/developer.dart	View	2 chunks	+3 lines, -4 lines	0 comments	Download
M	sdk/lib/_internal/js_runtime/lib/developer_patch.dart	View	3 chunks	+3 lines, -3 lines	0 comments	Download
M	sdk/lib/developer/developer.dart	View	1 chunk	+4 lines, -4 lines	0 comments	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Bill Hesse

On 2015/08/04 13:20:01, Bill Hesse wrote: > mailto:TBR=lrn@google.com Breaks buildbot: https://uberchromegw.corp.google.com/i/client.dart/builders/analyzer_experimental-linux-release-be/builds/2794 https://uberchromegw.corp.google.com/i/client.dart/builders/vm-win32-release-be/builds/12569 https://uberchromegw.corp.google.com/i/client.dart/builders/vm-win64-release-be/builds/7354

5 years, 4 months ago (2015-08-04 13:22:36 UTC) #3

Bill Hesse

Committed patchset #1 (id:1) manually as bdda0eff52d04bbaabfb66ef335276966a27d8ef (presubmit successful).

5 years, 4 months ago (2015-08-04 13:22:52 UTC) #4

Message was sent while issue was closed.

lgtm

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages