Issue 12611014: Cleanups in collection.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12611014: Cleanups in collection. (Closed)

Created:
7 years, 9 months ago by Lasse Reichstein Nielsen

Modified:
7 years, 9 months ago

Reviewers:
floitsch

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

More Reviews

Description

Cleanups in collection. Make SplayTreeMap throw on null key. Optimize first/last. Make DoubleLinkedQueue have fast length. Committed: https://code.google.com/p/dart/source/detail?r=19853

Patch Set 1 #

Total comments: 2

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+200 lines, -94 lines)			Patch
M	sdk/lib/collection/queue.dart	View	6 chunks	+20 lines, -5 lines	0 comments	Download
M	sdk/lib/collection/splay_tree.dart	View	11 chunks	+58 lines, -33 lines	2 comments	Download
M	tests/corelib/collection_length_test.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	tests/corelib/queue_test.dart	View	4 chunks	+120 lines, -55 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

floitsch

LGTM. https://codereview.chromium.org/12611014/diff/1/sdk/lib/collection/splay_tree.dart File sdk/lib/collection/splay_tree.dart (right): https://codereview.chromium.org/12611014/diff/1/sdk/lib/collection/splay_tree.dart#newcode138 sdk/lib/collection/splay_tree.dart:138: // After this, the least element in the ...

7 years, 9 months ago (2013-03-11 13:34:28 UTC) #2

Lasse Reichstein Nielsen

https://codereview.chromium.org/12611014/diff/1/sdk/lib/collection/splay_tree.dart File sdk/lib/collection/splay_tree.dart (right): https://codereview.chromium.org/12611014/diff/1/sdk/lib/collection/splay_tree.dart#newcode138 sdk/lib/collection/splay_tree.dart:138: // After this, the least element in the tree ...

7 years, 9 months ago (2013-03-12 12:01:06 UTC) #3

Lasse Reichstein Nielsen

7 years, 9 months ago (2013-03-12 12:01:07 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 manually as r19853 (presubmit successful).

Expand Messages | Collapse Messages