Issue 12610004: Start using the new union/intersection code for HType.INDEXABLE_PRIMITIVE.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 12610004: Start using the new union/intersection code for HType.INDEXABLE_PRIMITIVE. (Closed)

Created:
7 years, 9 months ago by kasperl

Modified:
7 years, 9 months ago

Reviewers:
ngeoffray

CC:
reviews_dartlang.org

Base URL:
https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Visibility:
Public.

Start using the new union/intersection code for HType.INDEXABLE_PRIMITIVE. R=ngeoffray@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=19668

Created: 7 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+45 lines, -17 lines)			Patch
M	sdk/lib/_internal/compiler/implementation/js_backend/backend.dart	View		2 chunks	+4 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/interceptors.dart	View		1 chunk	+9 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_array.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/lib/js_string.dart	View		1 chunk	+1 line, -1 line	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/bailout.dart	View		1 chunk	+6 lines, -0 lines	0 comments	Download
M	sdk/lib/_internal/compiler/implementation/ssa/types.dart	View	1 2 3 4	13 chunks	+15 lines, -10 lines	0 comments	Download
M	tests/compiler/dart2js/mock_compiler.dart	View		1 chunk	+3 lines, -2 lines	0 comments	Download
M	tests/compiler/dart2js/type_combination_test.dart	View		5 chunks	+6 lines, -3 lines	0 comments	Download

Total messages: 5 (0 generated)

kasperl

PTAL. The notion of HType.isExact seems a little weird. I can't wait until we can ...

7 years, 9 months ago (2013-03-07 13:54:56 UTC) #3

kasperl

7 years, 9 months ago (2013-03-08 05:38:20 UTC) #5

Message was sent while issue was closed.

Committed patchset #5 manually as r19668 (presubmit successful).