Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(514)

Issue 12608007: Reapply "Update the test runner to use the new dart:io API" (Closed)

Created:
7 years, 9 months ago by Søren Gjesse
Modified:
7 years, 9 months ago
Reviewers:
Mads Ager (google)
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Reapply "Update the test runner to use the new dart:io API" The Linux binary will work on the bots. Fixed a number of issues. The new binaries are from r19850. R=ager@google.com BUG= Committed: https://code.google.com/p/dart/source/detail?r=20004

Patch Set 1 #

Patch Set 2 : Minor fixes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+385 lines, -438 lines) Patch
M tests/standalone/io/status_file_parser_test.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/standalone/io/test_runner_test.dart View 3 chunks +4 lines, -4 lines 0 comments Download
M tests/standalone/standalone.status View 1 chunk +0 lines, -9 lines 0 comments Download
M tools/release/version.dart View 4 chunks +8 lines, -7 lines 0 comments Download
M tools/test.dart View 7 chunks +24 lines, -13 lines 0 comments Download
M tools/test-runtime.dart View 4 chunks +12 lines, -12 lines 0 comments Download
M tools/testing/bin/linux/dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/bin/macos/dart View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/bin/windows/dart.exe View 0 chunks +-1 lines, --1 lines 0 comments Download
M tools/testing/dart/co19_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tools/testing/dart/http_server.dart View 1 9 chunks +65 lines, -53 lines 0 comments Download
M tools/testing/dart/multitest.dart View 4 chunks +5 lines, -7 lines 0 comments Download
M tools/testing/dart/status_file_parser.dart View 2 chunks +33 lines, -36 lines 0 comments Download
M tools/testing/dart/test_options.dart View 2 chunks +9 lines, -9 lines 0 comments Download
M tools/testing/dart/test_progress.dart View 1 13 chunks +28 lines, -27 lines 0 comments Download
M tools/testing/dart/test_runner.dart View 22 chunks +144 lines, -208 lines 0 comments Download
M tools/testing/dart/test_suite.dart View 14 chunks +33 lines, -32 lines 0 comments Download
M tools/testing/dart/utils.dart View 3 chunks +7 lines, -8 lines 0 comments Download
M tools/testing/dart/vendored_pkg/args/src/usage.dart View 4 chunks +13 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Søren Gjesse
TBR'ed
7 years, 9 months ago (2013-03-14 11:38:53 UTC) #1
Søren Gjesse
Committed patchset #2 manually as r20004 (presubmit successful).
7 years, 9 months ago (2013-03-14 11:39:47 UTC) #2
Mads Ager (google)
7 years, 9 months ago (2013-03-14 11:56:31 UTC) #3
Message was sent while issue was closed.
lgtm

Powered by Google App Engine
This is Rietveld 408576698