Use offsetInBytes and not index in the get/set accessors of views.

Use offsetInBytes and not index in the get/set accessors of views.
Committed: https://code.google.com/p/dart/source/detail?r=20003

[Anders Johnsen, 2013-03-14 09:06:57]

LGTM

https://chromiumcodereview.appspot.com/12608006/diff/1/runtime/lib/typeddata.cc
File runtime/lib/typeddata.cc (right):

https://chromiumcodereview.appspot.com/12608006/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.cc:193: GET_NON_NULL_NATIVE_ARGUMENT(Smi, offsetInBytes,
arguments->NativeArgAt(1)); \
Random question: What if it's not a Smi? Do we want/need to support that?

[Florian Schneider, 2013-03-14 09:47:22]

LGTM.

https://chromiumcodereview.appspot.com/12608006/diff/1/runtime/lib/typeddata.cc
File runtime/lib/typeddata.cc (right):

https://chromiumcodereview.appspot.com/12608006/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.cc:193: GET_NON_NULL_NATIVE_ARGUMENT(Smi, offsetInBytes,
arguments->NativeArgAt(1)); \
On 2013/03/14 09:06:57, Anders Johnsen wrote:
> Random question: What if it's not a Smi? Do we want/need to support that?

Currently we don't. Arrays have a maximum length of kMaxSmi bytes.

[Florian Schneider, 2013-03-14 10:11:59]

https://chromiumcodereview.appspot.com/12608006/diff/1/runtime/lib/typeddata....
File runtime/lib/typeddata.dart (right):

https://chromiumcodereview.appspot.com/12608006/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.dart:484: int _getIndexedInt16(int index) {
It does not make a huge difference, but it may not be necessary to have
_getIndexedInt16 in the base class, but only in Int16Array. Same for the other
_getIndexedX/_setIndexedX functions.

[siva, 2013-03-14 11:16:34]

https://chromiumcodereview.appspot.com/12608006/diff/1/runtime/lib/typeddata.cc
File runtime/lib/typeddata.cc (right):

https://chromiumcodereview.appspot.com/12608006/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.cc:193: GET_NON_NULL_NATIVE_ARGUMENT(Smi, offsetInBytes,
arguments->NativeArgAt(1)); \
Yes, as Florian points out we have a length check before creating these arrays.

On 2013/03/14 09:47:22, Florian Schneider wrote:
> On 2013/03/14 09:06:57, Anders Johnsen wrote:
> > Random question: What if it's not a Smi? Do we want/need to support that?
> 
> Currently we don't. Arrays have a maximum length of kMaxSmi bytes.

https://chromiumcodereview.appspot.com/12608006/diff/1/runtime/lib/typeddata....
File runtime/lib/typeddata.dart (right):

https://chromiumcodereview.appspot.com/12608006/diff/1/runtime/lib/typeddata....
runtime/lib/typeddata.dart:484: int _getIndexedInt16(int index) {
True, I will move them to the respective classes.

On 2013/03/14 10:12:00, Florian Schneider wrote:
> It does not make a huge difference, but it may not be necessary to have
> _getIndexedInt16 in the base class, but only in Int16Array. Same for the other
> _getIndexedX/_setIndexedX functions.

[siva, 2013-03-14 11:38:23]

Committed patchset #3 manually as r20003 (presubmit successful).