Issue 1260793003: Fix ProfileCode ticking and add unit test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1260793003: Fix ProfileCode ticking and add unit test (Closed)

Created:
5 years, 4 months ago by Cutch

Modified:
5 years, 4 months ago

Reviewers:
rmacnak

CC:
reviews_dartlang.org, vm-dev_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Fix ProfileCode ticking and add unit test - Fix wrong loop indexer (two i variables...) use when ticking ProfileCode. - Factor out exclusive / inclusive tick decision into a helper function. - Adjust ProfileCode::Tick's semantics. - Add unit test verifying ProfileCode tick semantics. R=rmacnak@google.com Committed: https://github.com/dart-lang/sdk/commit/3d0b3b6b2b6d9b15ab7acb0246aa4426fbe4c7e6

Patch Set 1 #

Patch Set 2 : #

Total comments: 1

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+138 lines, -11 lines)			Patch
M	runtime/vm/profiler_service.h	View	1	1 chunk	+6 lines, -0 lines	0 comments	Download
M	runtime/vm/profiler_service.cc	View	1	4 chunks	+57 lines, -11 lines	0 comments	Download
M	runtime/vm/profiler_test.cc	View	1	1 chunk	+75 lines, -0 lines	1 comment	Download

Messages

Total messages: 5 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

rmacnak

https://codereview.chromium.org/1260793003/diff/20001/runtime/vm/profiler_test.cc File runtime/vm/profiler_test.cc (right): https://codereview.chromium.org/1260793003/diff/20001/runtime/vm/profiler_test.cc#newcode377 runtime/vm/profiler_test.cc:377: walker.Reset(Profile::kExclusiveCode); Seems weird to create a walker for exclusive ...

5 years, 4 months ago (2015-07-28 00:11:44 UTC) #3

Cutch

5 years, 4 months ago (2015-07-28 17:21:42 UTC) #5

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
3d0b3b6b2b6d9b15ab7acb0246aa4426fbe4c7e6 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages