Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1260503002: Fix for 'analysis.getNavigation' implementation. (Closed)

Created:
5 years, 5 months ago by scheglov
Modified:
5 years, 5 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Rollback accidential changes #

Unified diffs Side-by-side diffs Delta from patch set Stats (+95 lines, -21 lines) Patch
M pkg/analysis_server/lib/src/domain_analysis.dart View 3 chunks +39 lines, -8 lines 0 comments Download
M pkg/analysis_server/test/analysis/get_navigation_test.dart View 3 chunks +56 lines, -13 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
scheglov
5 years, 5 months ago (2015-07-24 16:44:41 UTC) #1
Brian Wilkerson
LGTM
5 years, 5 months ago (2015-07-24 17:37:38 UTC) #2
scheglov
5 years, 5 months ago (2015-07-24 21:27:17 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
14e1cdc86c3941746e555722f8a409ad4cc406b6 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698