Fix source generation for strings that have \$ in them.

Fix source generation for strings that have \$ in them.
Committed: https://code.google.com/p/dart/source/detail?r=20025

[bakster, 2013-03-14 13:45:04]

lgtm

[siva, 2013-03-14 14:12:40]

Committed patchset #1 manually as r20025 (presubmit successful).

[Ivan Posva, 2013-03-18 18:12:22]

Needs more work.

-Ivan

https://chromiumcodereview.appspot.com/12605009/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/12605009/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:4857: if ((literal.CharAt(i) == '$')) {
$ should be a SpecialCharacter and then you would not need this extra handling
here and in other places. Also as it is now if fails to properly escape $ in two
byte strings.

[siva, 2013-03-19 17:08:31]

https://chromiumcodereview.appspot.com/12605009/diff/1/runtime/vm/object.cc
File runtime/vm/object.cc (right):

https://chromiumcodereview.appspot.com/12605009/diff/1/runtime/vm/object.cc#n...
runtime/vm/object.cc:4857: if ((literal.CharAt(i) == '$')) {
The raw string processing was interfering with treating this as a Special
character. I have a CL uploaded that always translates raw strings to regular
strings and does not attempt to preserve raw strings as is in the generated
code.

That should avoid this problem.

On 2013/03/18 18:12:22, Ivan Posva wrote:
> $ should be a SpecialCharacter and then you would not need this extra handling
> here and in other places. Also as it is now if fails to properly escape $ in
two
> byte strings.