Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(249)

Issue 12605003: Converting Element.client*, offset* and Screen.avail* over to Rects (Closed)

Created:
7 years, 9 months ago by blois
Modified:
7 years, 9 months ago
CC:
reviews_dartlang.org
Visibility:
Public.

Description

Converting Element.client*, offset* and Screen.avail* over to Rects Converting more APIs over to exposing as Rects. BUG= Committed: https://code.google.com/p/dart/source/detail?r=19702

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+189 lines, -58 lines) Patch
M samples/swarm/Views.dart View 1 chunk +1 line, -1 line 0 comments Download
M samples/swarm/swarm_ui_lib/layout/ViewLayout.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/swarm/swarm_ui_lib/touch/Scroller.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/swarm/swarm_ui_lib/view/PagedViews.dart View 3 chunks +3 lines, -3 lines 0 comments Download
M samples/swarm/swarm_ui_lib/view/SliderMenu.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M samples/swarm/swarm_ui_lib/view/view.dart View 1 chunk +1 line, -1 line 0 comments Download
M sdk/lib/html/dart2js/html_dart2js.dart View 5 chunks +64 lines, -13 lines 0 comments Download
M sdk/lib/html/dartium/html_dartium.dart View 6 chunks +52 lines, -16 lines 0 comments Download
M sdk/lib/svg/dart2js/svg_dart2js.dart View 2 chunks +4 lines, -2 lines 0 comments Download
M sdk/lib/svg/dartium/svg_dartium.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M tests/html/element_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tools/dom/scripts/htmlrenamer.py View 4 chunks +14 lines, -0 lines 0 comments Download
M tools/dom/templates/html/impl/impl_Element.darttemplate View 1 chunk +32 lines, -0 lines 0 comments Download
A + tools/dom/templates/html/impl/impl_Screen.darttemplate View 1 chunk +6 lines, -10 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
blois
7 years, 9 months ago (2013-03-07 23:42:16 UTC) #1
Jennifer Messerly
lgtm
7 years, 9 months ago (2013-03-08 04:00:48 UTC) #2
blois
7 years, 9 months ago (2013-03-08 18:12:27 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r19702 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698