Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(505)

Issue 1260443006: Make PathFilter use the resource providers path context (Closed)

Created:
5 years, 4 months ago by Brian Wilkerson
Modified:
5 years, 4 months ago
Reviewers:
Paul Berry
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Make PathFilter use the resource providers path context R=paulberry@google.com Committed: https://github.com/dart-lang/sdk/commit/24189ea4f965d8e018105fbbe9c727cea705e842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+41 lines, -33 lines) Patch
M pkg/analysis_server/lib/src/context_manager.dart View 1 chunk +5 lines, -3 lines 0 comments Download
M pkg/analyzer/lib/source/path_filter.dart View 3 chunks +23 lines, -19 lines 0 comments Download
M pkg/analyzer/test/source/path_filter_test.dart View 2 chunks +13 lines, -11 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Brian Wilkerson
I think this should solve at least one problem on the Windows bot, but I ...
5 years, 4 months ago (2015-07-31 16:31:05 UTC) #2
Paul Berry
lgtm
5 years, 4 months ago (2015-07-31 16:56:45 UTC) #3
Brian Wilkerson
5 years, 4 months ago (2015-07-31 17:06:43 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
24189ea4f965d8e018105fbbe9c727cea705e842 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698